chore(switch): update swipe interaction docs #1096
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After resolving openui#1045, this pull request removes the question and defines a swipe interaction with reference to the resolution.
gfellerph
requested review from
gregwhitworth,
mfreed7 and
dbaron
as code owners
gregwhitworth
approved these changes
Sep 29, 2024
| From a user standpoint, the following interactions should be supported | ||
|
|
||
| - Click/tap: toggles the switch | ||
| - <kbd>Spacebar</kbd>: toggles the switch which has keyboard focus | ||
| - Swipe: Switch should support gesture support akin to the range control ([#1045](https://github.com/openui/open-ui/issues/1045)) |
There was a problem hiding this comment.
Can you please link to the MDN documentation of the range control?
tantek
requested changes
Oct 3, 2024
Co-authored-by: Tantek Çelik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After resolving #1045, this pull request removes the question and defines a swipe interaction with reference to the resolution.